Use level 9 Zlib compression#7513
Merged
Merged
Conversation
|
devongovett
approved these changes
Jan 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Use max-level compression for Gzip by default. As far as I know
BROTLI_DEFAULT_QUALITY == BROTLI_MAX_QUALITY, so max-level compression is already done in the Brotli compressor by default.Closes #7087
Not really much to test here. This is a minor improvement in compression quality for ~50% slower performance in my experience, but most web assets are so tiny that this performance hit really doesn't matter for build times, while the bytes saved could be nice for production.