Support Node V18, future Deno versions, reduce install size, better performance#7979
Merged
Conversation
Member
|
Please run |
Member
|
Have you seen this native crash in the integration test that failed on CI? |
Contributor
Author
|
Yes, I did see that, looking into (trying to reproduce). Thanks for letting me know too though. |
kriszyp
added a commit
to kriszyp/lmdb-js
that referenced
this pull request
Apr 21, 2022
…g CI test failure from parcel-bundler/parcel#7979
Contributor
Author
|
Do you have any advice on how to interpret the latest CI failure? It seems like I fixed the original issue, but it is not clear to my why the benchmark run is failing (babel errors?) and how that would be caused by lmdb? And it seems other failures were reported, but since resolved? |
mischnic
approved these changes
Apr 22, 2022
mischnic
left a comment
Member
There was a problem hiding this comment.
The failing benchmark is unrelated and doesn't block PR merging.
|
what's the status of this ticket? I still can't install without errors when using node 18 on Windows 11. Works fine on MacOS Catalina. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Just an upgrade of lmdb-js, but could help with a few things. I did (regression) test with one of the repro repo from #7702, seems like everything was working fine.