Skip to content

Support Node V18, future Deno versions, reduce install size, better performance#7979

Merged
mischnic merged 1 commit into
parcel-bundler:v2from
kriszyp:upgrade-lmdb
Apr 22, 2022
Merged

Support Node V18, future Deno versions, reduce install size, better performance#7979
mischnic merged 1 commit into
parcel-bundler:v2from
kriszyp:upgrade-lmdb

Conversation

@kriszyp

@kriszyp kriszyp commented Apr 19, 2022

Copy link
Copy Markdown
Contributor

↪️ Pull Request

Just an upgrade of lmdb-js, but could help with a few things. I did (regression) test with one of the repro repo from #7702, seems like everything was working fine.

@mischnic

mischnic commented Apr 19, 2022

Copy link
Copy Markdown
Member

Please run yarn and commit the lockfile change

@mischnic

Copy link
Copy Markdown
Member

Have you seen this native crash in the integration test that failed on CI?

/opt/hostedtoolcache/node/14.19.1/x64/bin/node[9839]: ../src/env-inl.h:1161:void node::Environment::AddCleanupHook(node::Environment::CleanupCallback, void*): Assertion `(insertion_info.second) == (true)' failed.
 1: 0xa3aaf0 node::Abort() [/opt/hostedtoolcache/node/14.19.1/x64/bin/node]
 2: 0xa3ab6e  [/opt/hostedtoolcache/node/14.19.1/x64/bin/node]
 3: 0x99537a  [/opt/hostedtoolcache/node/14.19.1/x64/bin/node]
 4: 0xa07907 napi_add_env_cleanup_hook [/opt/hostedtoolcache/node/14.19.1/x64/bin/node]
 5: 0x7fb18c2001a5  [/home/runner/work/parcel/parcel/node_modules/lmdb-linux-x64/node.napi.glibc.node]
 6: 0x7fb18c203ef4  [/home/runner/work/parcel/parcel/node_modules/lmdb-linux-x64/node.napi.glibc.node]
 7: 0x9eaa8d  [/opt/hostedtoolcache/node/14.19.1/x64/bin/node]
 8: 0xc262eb  [/opt/hostedtoolcache/node/14.19.1/x64/bin/node]
 9: 0xc27896  [/opt/hostedtoolcache/node/14.19.1/x64/bin/node]
10: 0xc27f16 v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) [/opt/hostedtoolcache/node/14.19.1/x64/bin/node]
11: 0x1448ef9  [/opt/hostedtoolcache/node/14.19.1/x64/bin/node]

@kriszyp

kriszyp commented Apr 20, 2022

Copy link
Copy Markdown
Contributor Author

Yes, I did see that, looking into (trying to reproduce). Thanks for letting me know too though.

kriszyp added a commit to kriszyp/lmdb-js that referenced this pull request Apr 21, 2022
@kriszyp

kriszyp commented Apr 22, 2022

Copy link
Copy Markdown
Contributor Author

Do you have any advice on how to interpret the latest CI failure? It seems like I fixed the original issue, but it is not clear to my why the benchmark run is failing (babel errors?) and how that would be caused by lmdb? And it seems other failures were reported, but since resolved?

@mischnic mischnic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing benchmark is unrelated and doesn't block PR merging.

@chryssajones

chryssajones commented Jul 8, 2023

Copy link
Copy Markdown

what's the status of this ticket? I still can't install without errors when using node 18 on Windows 11. Works fine on MacOS Catalina.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Attempting to install parcel on node@18.0.0 under Windows fails

3 participants