Skip to content

Fix Vue pug rendering by specifying HTML5 by default#8051

Merged
devongovett merged 7 commits into
parcel-bundler:v2from
Jengamon:doctype-pug-fix
May 8, 2022
Merged

Fix Vue pug rendering by specifying HTML5 by default#8051
devongovett merged 7 commits into
parcel-bundler:v2from
Jengamon:doctype-pug-fix

Conversation

@Jengamon

@Jengamon Jengamon commented May 3, 2022

Copy link
Copy Markdown
Contributor

↪️ Pull Request

For the pug template engine for Vue, make HTML5 the default. This will fix #7756.
See discussion at #8050 for considerations about this change.

💻 Examples

<template lang="pug">

.wrapper

	p(v-if="false") foo
	p(v-else) bug

</template>

should now render properly without any workarounds.

🚨 Test instructions

I will add the above example as an integration test.

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@Jengamon

Jengamon commented May 3, 2022

Copy link
Copy Markdown
Contributor Author

Does this need a whole integration test?

@devongovett devongovett requested a review from 101arrowz May 8, 2022 15:58

@101arrowz 101arrowz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread packages/transformers/vue/src/VueTransformer.js Outdated
@devongovett devongovett merged commit 1568064 into parcel-bundler:v2 May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vue 3: "v-else" conditional compilation error in Pug template (SFC)

3 participants