Skip to content

Forward useDefineForClassFields to swc#8107

Merged
devongovett merged 2 commits into
v2from
useDefineForClassFields
May 21, 2022
Merged

Forward useDefineForClassFields to swc#8107
devongovett merged 2 commits into
v2from
useDefineForClassFields

Conversation

@mischnic

@mischnic mischnic commented May 18, 2022

Copy link
Copy Markdown
Member

Fixes #8036

Also a non-breaking swc bump to fix swc-project/swc#4703

@mischnic mischnic force-pushed the useDefineForClassFields branch from 4a79f81 to 39ee2d4 Compare May 18, 2022 21:47
@parcel-benchmark

parcel-benchmark commented May 18, 2022

Copy link
Copy Markdown

Benchmark Results

Kitchen Sink 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

React HackerNews ✅

Timings

Description Time Difference
Cold 9.32s -21.00ms
Cached 456.00ms -15.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.66m -123.00ms
Cached 2.65s +29.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/index.34edd600.js 3.33mb +144.00b ⚠️ 32.50s +330.00ms
dist/16.069344b7.js 905.00b +0.00b 40.99s +4.42s ⚠️
dist/simpleHasher.46d6f2e5.js 742.00b +0.00b 1.24m +33.93s ⚠️
dist/index.html 240.00b +0.00b 35.80s +3.58s ⚠️

Cached Bundles

No bundle changes detected.

Three.js ✅

Timings

Description Time Difference
Cold 6.92s +23.00ms
Cached 277.00ms -16.00ms 🚀

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@devongovett devongovett merged commit 9a44f02 into v2 May 21, 2022
@devongovett devongovett deleted the useDefineForClassFields branch May 21, 2022 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants