Skip to content

Fix atomic writestream handling on Windows#8337

Merged
mischnic merged 2 commits into
v2from
mischnic-patch-1
Jul 26, 2022
Merged

Fix atomic writestream handling on Windows#8337
mischnic merged 2 commits into
v2from
mischnic-patch-1

Conversation

@mischnic

@mischnic mischnic commented Jul 24, 2022

Copy link
Copy Markdown
Member

These __... properties were never defined...

Might be related to #8257

@parcel-benchmark

parcel-benchmark commented Jul 24, 2022

Copy link
Copy Markdown

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 2.09s +32.00ms
Cached 468.00ms +34.00ms ⚠️

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/index.html 826.00b +0.00b 748.00ms -51.00ms 🚀
dist/modern/index.html 749.00b +0.00b 748.00ms -50.00ms 🚀
dist/legacy/index.b8ae99ba.css 94.00b +0.00b 341.00ms -22.00ms 🚀
dist/modern/index.31cedca9.css 94.00b +0.00b 340.00ms -22.00ms 🚀

React HackerNews ✅

Timings

Description Time Difference
Cold 12.24s -205.00ms
Cached 559.00ms -7.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 2.25m -726.00ms
Cached 3.18s -30.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Three.js ✅

Timings

Description Time Difference
Cold 8.97s +119.00ms
Cached 360.00ms -1.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@mischnic mischnic merged commit 411d4c2 into v2 Jul 26, 2022
@mischnic mischnic deleted the mischnic-patch-1 branch July 26, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants