Add support for errorRecovery option in @parcel/transformer-css#8352
Merged
Conversation
mischnic
approved these changes
Jul 31, 2022
mischnic
left a comment
Member
There was a problem hiding this comment.
Unrelated: We probably want to validate the css transformer config with a schema at some point.
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached BundlesNo bundle changes detected. React HackerNews ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. AtlasKit Editor ✅
Timings
Cold Bundles
Cached BundlesNo bundle changes detected. Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. |
…recovery # Conflicts: # yarn.lock
5b6595c to
6a89a0b
Compare
peterkeating
added a commit
to EtchUK/Etch.OrchardCore.ThemeBoilerplate
that referenced
this pull request
Oct 5, 2022
- Removed all webpack related configurations and dependencies - Add parcel as dependency - Moved static imagery to wwwroot as it's not longer moved as part of the build process unless it's referenced directly in the CSS/TypeScript - Needed to use `errorRecovery` option due to lightgallery using out of date CSS techniques for clearfix - parcel-bundler/parcel#8352 - Removed content hashing using custom namer due to fonts being preloaded in HTML, thus the name can't be changed for each build - Rename output folders/filenames to match other team's approach
peterkeating
added a commit
to EtchUK/Etch.OrchardCore.ThemeBoilerplate
that referenced
this pull request
Oct 6, 2022
- Removed all webpack related configurations and dependencies - Add parcel as dependency - Moved static imagery to wwwroot as it's not longer moved as part of the build process unless it's referenced directly in the CSS/TypeScript - Needed to use `errorRecovery` option due to lightgallery using out of date CSS techniques for clearfix - parcel-bundler/parcel#8352 - Removed content hashing using custom namer due to fonts being preloaded in HTML, thus the name can't be changed for each build - Rename output folders/filenames to match other team's approach - Add linting via eslint & stylelint - Perform linting & prettier via pre-commit git hook
peterkeating
added a commit
to EtchUK/Etch.OrchardCore.ThemeBoilerplate
that referenced
this pull request
Oct 17, 2022
- Removed all webpack related configurations and dependencies - Add parcel as dependency - Moved static imagery to wwwroot as it's not longer moved as part of the build process unless it's referenced directly in the CSS/TypeScript - Needed to use `errorRecovery` option due to lightgallery using out of date CSS techniques for clearfix - parcel-bundler/parcel#8352 - Removed content hashing using custom namer due to fonts being preloaded in HTML, thus the name can't be changed for each build - Rename output folders/filenames to match other team's approach - Add linting via eslint & stylelint - Perform linting & prettier via pre-commit git hook
peterkeating
added a commit
to EtchUK/Etch.OrchardCore.ThemeBoilerplate
that referenced
this pull request
Oct 17, 2022
- Removed all webpack related configurations and dependencies - Add parcel as dependency - Moved static imagery to wwwroot as it's not longer moved as part of the build process unless it's referenced directly in the CSS/TypeScript - Needed to use `errorRecovery` option due to lightgallery using out of date CSS techniques for clearfix - parcel-bundler/parcel#8352 - Removed content hashing using custom namer due to fonts being preloaded in HTML, thus the name can't be changed for each build - Rename output folders/filenames to match other team's approach - Add linting via eslint & stylelint - Perform linting & prettier via pre-commit git hook
peterkeating
added a commit
to EtchUK/Etch.OrchardCore.ThemeBoilerplate
that referenced
this pull request
Oct 17, 2022
- Removed all webpack related configurations and dependencies - Add parcel as dependency - Moved static imagery to wwwroot as it's not longer moved as part of the build process unless it's referenced directly in the CSS/TypeScript - Needed to use `errorRecovery` option due to lightgallery using out of date CSS techniques for clearfix - parcel-bundler/parcel#8352 - Removed content hashing using custom namer due to fonts being preloaded in HTML, thus the name can't be changed for each build - Rename output folders/filenames to match other team's approach - Add linting via eslint & stylelint - Perform linting & prettier via pre-commit git hook
gorakong
pushed a commit
that referenced
this pull request
Nov 3, 2022
* upstream/v2: (22 commits) Cross compile toolchains are built into docker image already Also fix release build Update centos node version v2.7.0 Changelog for v2.7.0 Use placeholder expression when replacing unused symbols (#8358) Lint (#8359) Add support for errorRecovery option in @parcel/transformer-css (#8352) VS Code Extension for Parcel (#8139) Add multi module compilation for elm (#8076) Bump terser from 5.7.2 to 5.14.2 (#8322) Bump node-forge from 1.2.1 to 1.3.0 (#8271) allow cjs config files on type module projects (#8253) inject script for hmr when there is only normal script in html (#8330) feat: support react refresh for @emotion/react (#8205) Update index.d.ts (#8293) remove charset from jsloader script set (#8346) Log resolved targets in verbose log level (#8254) Fix missing module in large app from Experimental Bundler (#8303) [Symbol Propagation] Non-deterministic bundle hashes (#8212) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When enabled in the config in package.json, Parcel CSS will skip over invalid rules and declarations and emit warnings instead.