Fix types of core getConfig#8362
Merged
devongovett merged 2 commits intoOct 25, 2022
Merged
Conversation
devongovett
approved these changes
Oct 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Previously
getConfigwas typed in flow as:This generates the ts type definition
Unfortunately, this means the second argument is required in typescript when it’s really not. This PR makes it so the corresponding type definitions of typescript mark the argument as optional.
💻 Examples
N/A
🚨 Test instructions
Run
npm run build-tsand see if the output correctly generates optional types forgetConfigandgetConfigFrom.✔️ PR Todo