Skip to content

Fix SW packaging in web extensions #8424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devongovett merged 2 commits into from
Oct 24, 2022
Merged

Fix SW packaging in web extensions #8424

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03e650b
Fix SW packaging in web extensions
olistic Aug 28, 2022
6df208f
Fix typo
olistic Oct 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/packagers/webextension/src/WebExtensionPackager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,13 @@ export default (new Packager({
relativeBundlePath(bundle, b, {leadingDotSlash: false});

const manifest = JSON.parse(await asset.getCode());

if (manifest.background?.type === 'module') {
// service workers are built with output format 'global'
// see: https://github.com/parcel-bundler/parcel/blob/3329469f50de9326c5b02ef0ab1c0ce41393279c/packages/transformers/js/src/JSTransformer.js#L577
delete manifest.background.type;
}

const deps = asset.getDependencies();
const war = [];
for (const contentScript of manifest.content_scripts || []) {
Expand Down
⚡