Skip to content

Fix verbose warning: reexport all doesn't include default#8451

Merged
mischnic merged 1 commit into
v2from
fix-verbose-symbol-warning
Sep 12, 2022
Merged

Fix verbose warning: reexport all doesn't include default#8451
mischnic merged 1 commit into
v2from
fix-verbose-symbol-warning

Conversation

@mischnic

@mischnic mischnic commented Sep 7, 2022

Copy link
Copy Markdown
Member

Fixes some verbose warnings that were false positives such as:
@parcel/core: node_modules/ky-universal/browser.js reexports "default", which could be resolved either to the dependency "ky" or "ky" at runtime. Adding a namespace object to fall back on.

Test case (but not added because the symbol data is identical and asserting log messages is hard)

// index.js
import a from "./a.js";
console.log(a);

// a.js
export { default } from "./b.js";
export * from "./b.js";

// b.js
export default "def";
export const b = "b";

@parcel-benchmark

parcel-benchmark commented Sep 7, 2022

Copy link
Copy Markdown

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 1.38s +5.00ms
Cached 310.00ms -3.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

React HackerNews 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

AtlasKit Editor 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

Three.js ✅

Timings

Description Time Difference
Cold 6.45s +31.00ms
Cached 272.00ms -5.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@mischnic mischnic force-pushed the fix-verbose-symbol-warning branch from 5161a3d to 9d83c69 Compare September 12, 2022 07:50
@mischnic mischnic merged commit 3678a9f into v2 Sep 12, 2022
@mischnic mischnic deleted the fix-verbose-symbol-warning branch September 12, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants