Fix #8500 by not adding offset to line numbers#8501
Merged
Conversation
Member
|
Can you add a test case to https://github.com/parcel-bundler/parcel/blob/v2/packages/core/integration-tests/test/vue.js for this example? So duplicate https://github.com/parcel-bundler/parcel/tree/v2/packages/core/integration-tests/test/integration/vue-basic and make it fail with an error like in your screenshot, then add an assertion like this one parcel/packages/core/integration-tests/test/javascript.js Lines 1719 to 1757 in e3a39a1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8500
Code snippet previews work after applying this patch, and the line numbers make sense again: