Allow source maps files in webextension#8541
Merged
101arrowz merged 4 commits intoJun 2, 2023
Merged
Conversation
a7bc074 to
e17d6b6
Compare
e17d6b6 to
a0e92a6
Compare
101arrowz
requested changes
Jun 2, 2023
101arrowz
approved these changes
Jun 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Fixes #8530 — there was no way to generate source map files when you are making a web extension.
💻 Examples
With this fix it still defaults to inline source maps, but you can overwrite it:
🚨 Test instructions
There don't seem to be tests for this part of the code, but with the example above you can easily see that it generates
.mapfiles when using that config with this Parcel config:{ "extends": "@parcel/config-webextension" }✔️ PR Todo