Ensure edge exists before removal in Graph.removeEdge

[mattcompiles]

↪️ Pull Request

Prior to PR #7927, removeEdge validated that an edge existed before attempting to remove it. The assertions were removed as the recursive nature of removeEdge could lead to edges being deleted twice.

While ignoring double removals makes sense when orphaned nodes/edges are being cleaned up, it's not ideal when calling into removeEdge externally. It can lead to a confusing developer experience where removeEdge is called incorrectly on edges that don't exist but the Graph just silently ignores the request.

This PR splits removeEdge into separate private and public APIs.

• _removeEdge - only used internally to the Graph, ignores edge delete requests that don't exist
• removeEdge - validates the edge exists and then calls _removeEdge, throws if the edge doesn't exist

One drawback of this approach is that calls to removeEdge validate that the edge exists twice.

💻 Examples

let graph = new Graph();
let nodeA = graph.addNode('a');
let nodeB = graph.addNode('b');

assert.throws(() => {
  graph.removeEdge(nodeA, nodeB);
}, /Edge from 0 to 1 not found!/);

✔️ PR Todo

• Added/updated unit tests for this change
• Filled out test instructions (In case there aren't any unit tests)
• Included links to related issues/PRs

[parcel-benchmark]

Benchmark Results

Kitchen Sink ✅

Timings

Description	Time	Difference
Cold	1.36s	+7.00ms
Cached	298.00ms	-32.00ms 🚀

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

React HackerNews 🚨

Timings

Description	Time	Difference
Cold	FAILED	-0.00ms
Cached	FAILED	-0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

AtlasKit Editor 🚨

Timings

Description	Time	Difference
Cold	FAILED	-0.00ms
Cached	FAILED	-0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

Three.js ✅

Timings

Description	Time	Difference
Cold	6.33s	-78.00ms
Cached	290.00ms	+13.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

[yrral86]

After upgrading to 2.8.0, I am seeing

🚨 Build failed.

@parcel/bundler-default: Edge from 2050 to 2051 not found!

  Error: Edge from 2050 to 2051 not found!
      at ContentGraph.removeEdge (/redacted/node_modules/@parcel/graph/lib/Graph.js:156:13)
      at MutableBundleGraph.createBundleGroup (/redacted/node_modules/@parcel/core/lib/public/MutableBundleGraph.js:134:24)
      at decorateLegacyGraph (/redacted/node_modules/@parcel/bundler-default/lib/DefaultBundler.js:159:35)
      at Object.bundle (/redacted/node_modules/@parcel/bundler-default/lib/DefaultBundler.js:126:7)
      at BundlerRunner.bundle (/redacted/node_modules/@parcel/core/lib/requests/BundleGraphRequest.js:288:23)
      at async Object.run (/redacted/node_modules/@parcel/core/lib/requests/BundleGraphRequest.js:156:17)
      at async RequestTracker.runRequest (/redacted/node_modules/@parcel/core/lib/RequestTracker.js:756:20)
      at async Object.run (/redacted/node_modules/@parcel/core/lib/requests/ParcelBuildRequest.js:56:7)
      at async RequestTracker.runRequest (/redacted/node_modules/@parcel/core/lib/RequestTracker.js:756:20)
      at async Parcel._build (/redacted/node_modules/@parcel/core/lib/Parcel.js:400:11)