Don't retarget dependencies with *

[mischnic]

Fixes #8624

It doesn't really make sense to do retargeting if the dependency has a used * symbols, because the retargeting won't enable any benefits in that case (apart from potentially even more code being generated).

Furthermore, that fixes a bug where a dependency with symbols * -> * was split into two (one for the used * and one for a specific symbol itself) which really confused this code:

parcel/packages/packagers/js/src/ScopeHoistingPackager.js

Lines 1063 to 1080 in fbe9fde

	// If the resolved asset has an exports object, use the $parcel$exportWildcard helper
	// to re-export all symbols. Otherwise, if there's no namespace object available, add
	// $parcel$export calls for each used symbol of the dependency.
	if (
	isWrapped ||
	resolved.meta.staticExports === false ||
	nullthrows(this.bundleGraph.getUsedSymbols(resolved)).has('*') ||
	// an empty asset
	(!resolved.meta.hasCJSExports &&
	resolved.symbols.hasExportSymbol('*'))
	) {
	let obj = this.getSymbolResolution(asset, resolved, '*', dep);
	append += `$parcel$exportWildcard($${assetId}$exports, ${obj});\n`;
	this.usedHelpers.add('$parcel$exportWildcard');
	} else {
	for (let symbol of nullthrows(
	this.bundleGraph.getUsedSymbols(dep),
	)) {

[parcel-benchmark]

Benchmark Results

Kitchen Sink ✅

Timings

Description	Time	Difference
Cold	1.53s	-48.00ms
Cached	364.00ms	+16.00ms

Cold Bundles

Bundle	Size	Difference	Time	Difference
dist/legacy/parcel.7cdb0fad.webp	102.94kb	+0.00b	93.00ms	+10.00ms ⚠️
dist/legacy/parcel.7cdb0fad.webp	102.94kb	+0.00b	94.00ms	+10.00ms ⚠️
dist/modern/parcel.7cdb0fad.webp	102.94kb	+0.00b	93.00ms	+9.00ms ⚠️
dist/modern/index.31cedca9.css	94.00b	+0.00b	267.00ms	+14.00ms ⚠️

Cached Bundles

Bundle	Size	Difference	Time	Difference
dist/legacy/parcel.7cdb0fad.webp	102.94kb	+0.00b	90.00ms	+9.00ms ⚠️
dist/legacy/parcel.7cdb0fad.webp	102.94kb	+0.00b	91.00ms	+9.00ms ⚠️
dist/modern/parcel.7cdb0fad.webp	102.94kb	+0.00b	90.00ms	+7.00ms ⚠️
dist/legacy/index.html	826.00b	+0.00b	573.00ms	+34.00ms ⚠️
dist/modern/index.html	749.00b	+0.00b	573.00ms	+34.00ms ⚠️
dist/legacy/index.b8ae99ba.css	94.00b	+0.00b	270.00ms	+21.00ms ⚠️
dist/modern/index.31cedca9.css	94.00b	+0.00b	270.00ms	+21.00ms ⚠️

React HackerNews ✅

Timings

Description	Time	Difference
Cold	9.84s	+313.00ms
Cached	448.00ms	-21.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description	Time	Difference
Cold	1.77m	+1.55s
Cached	2.24s	-179.00ms 🚀

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Three.js ✅

Timings

Description	Time	Difference
Cold	6.80s	-208.00ms
Cached	292.00ms	+22.00ms ⚠️

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.