Skip to content

fix: add extra information to unique bundles #8784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devongovett merged 2 commits into from
Feb 1, 2023
Merged

fix: add extra information to unique bundles #8784

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd73786
fix: add extra information to unique bundles
tristan-f-r Jan 22, 2023
bd7d6fd
fix: use setDifference to avoid error clutter
tristan-f-r Jan 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/core/core/src/requests/BundleGraphRequest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import MutableBundleGraph from '../public/MutableBundleGraph';
import {Bundle, NamedBundle} from '../public/Bundle';
import {report} from '../ReporterRunner';
import dumpGraphToGraphViz from '../dumpGraphToGraphViz';
import {unique} from '@parcel/utils';
import {unique, setDifference} from '@parcel/utils';
import {hashString} from '@parcel/hash';
import PluginOptions from '../public/PluginOptions';
import applyRuntimes from '../applyRuntimes';
Expand Down Expand Up @@ -420,7 +420,10 @@ class BundlerRunner {
assert.deepEqual(
bundleNames,
unique(bundleNames),
'Bundles must have unique names',
'Bundles must have unique name. Conflicting names: ' +
[
...setDifference(new Set(bundleNames), new Set(unique(bundleNames))),
].join(),
);
}

Expand Down
⚡