Sort global deps before injecting imports

[mattcompiles]

↪️ Pull Request

The global replacer currently injects imports to polyfills for node global APIs, however their order is not consistent between builds. This can be due to SWC not visiting the expressions in order or HashMap not storing values in insertion order.

The PR sorts globals by key before inserting them to ensure consistent ordering between builds.
This PR switches HashMap for IndexMap which respects insertion order.

🚨 Test instructions

Existing tests are sufficient.

✔️ PR Todo

• Added/updated unit tests for this change
• Filled out test instructions (In case there aren't any unit tests)
• Included links to related issues/PRs

[parcel-benchmark]

Benchmark Results

Kitchen Sink ✅

Timings

Description	Time	Difference
Cold	1.41s	-1.00ms
Cached	331.00ms	+2.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle	Size	Difference	Time	Difference
dist/legacy/parcel.7cdb0fad.webp	102.94kb	+0.00b	89.00ms	+5.00ms ⚠️
dist/modern/parcel.7cdb0fad.webp	102.94kb	+0.00b	90.00ms	+5.00ms ⚠️

React HackerNews ✅

Timings

Description	Time	Difference
Cold	9.19s	-37.00ms
Cached	412.00ms	-19.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description	Time	Difference
Cold	1.52m	+786.00ms
Cached	2.23s	+73.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Three.js ✅

Timings

Description	Time	Difference
Cold	6.51s	-60.00ms
Cached	264.00ms	+4.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

[mischnic]

Haven't we tried to use indexedmap at some point for some part of the transformer but then went with arrays for some reason? Was it performance? @devongovett

--- packages/transformers/js/core/Cargo.toml
+++ packages/transformers/js/core/Cargo.toml
@@ -20,3 +20,4 @@ sha-1 = "0.10.0"
 dunce = "1.0.1"
 pathdiff = "0.2.0"
 path-slash = "0.1.4"
+indexmap = "1.9.2"
diff --git packages/transformers/js/core/src/global_replacer.rs packages/transformers/js/core/src/global_replacer.rs
index e249e6da2..80ed0a56a 100644
--- packages/transformers/js/core/src/global_replacer.rs
+++ packages/transformers/js/core/src/global_replacer.rs
@@ -1,7 +1,8 @@
 use path_slash::PathBufExt;
-use std::collections::{HashMap, HashSet};
+use std::collections::HashSet;
 use std::path::Path;
 
+use indexmap::IndexMap;
 use swc_atoms::JsWord;
 use swc_common::{Mark, SourceMap, SyntaxContext, DUMMY_SP};
 use swc_ecmascript::ast::{self, ComputedPropName, Id};
@@ -14,9 +15,10 @@ pub struct GlobalReplacer<'a> {
   pub source_map: &'a SourceMap,
   pub items: &'a mut Vec<DependencyDescriptor>,
   pub global_mark: Mark,
-  pub globals: HashMap<JsWord, (SyntaxContext, ast::Stmt)>,
+  pub globals: IndexMap<JsWord, (SyntaxContext, ast::Stmt)>,
   pub project_root: &'a Path,
   pub filename: &'a Path,
   pub decls: &'a mut HashSet<Id>,
   pub scope_hoist: bool,
 }
diff --git packages/transformers/js/core/src/lib.rs packages/transformers/js/core/src/lib.rs
index e0d51e61b..b8497eb33 100644
--- packages/transformers/js/core/src/lib.rs
+++ packages/transformers/js/core/src/lib.rs
@@ -22,6 +22,7 @@ mod node_replacer;
 mod typeof_replacer;
 mod utils;
 
+use indexmap::IndexMap;
 use std::collections::{HashMap, HashSet};
 use std::path::{Path, PathBuf};
 use std::str::FromStr;
@@ -369,7 +370,7 @@ pub fn transform(config: Config) -> Result<TransformResult, std::io::Error> {
                       source_map: &source_map,
                       items: &mut global_deps,
                       global_mark,
-                      globals: HashMap::new(),
+                      globals: IndexMap::new(),
                       project_root: Path::new(&config.project_root),
                       filename: Path::new(&config.filename),
                       decls: &mut decls,