Fixup DiagnosticCodeHighlight and SourceLocation columns#8965
Merged
Conversation
# Conflicts: # yarn.lock
devongovett
approved these changes
May 12, 2023
Member
|
Seems like a test is failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was always (supposed to be) the case that:
DiagnosticCodeHighlightis 1-based and the end location is inclusiveSourceLocationis 1-based and the end is exclusiveBut due to two cancelling off-by-one errors, many
SourceLocationhad an incorrect end position.This caused problems when bumping Babel (causing more accurate sourcemaps) which caused some wrong locations to be remapped.