Hoist exports to allow circular dependencies#9024
Merged
Merged
Conversation
…nce and named default export function and fix
Member
|
Please remove the comments and the |
mischnic
approved these changes
May 18, 2023
mischnic
left a comment
mischnic
left a comment
Member
There was a problem hiding this comment.
(I also renamed the tests to be more inline with the existing test/integration/js-export-default-* fixture folders)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤒 Pull Request
This PR aims to fix an issue where circular dependencies with a exported function is not defined at runtime. Both anonymous and named
export default functionshould be hoisted, where asexport default classshould not as it is not supported by node.😶🌫️ Examples
Without the fix, the test cases added below would result in a
function is not definedorb1() is not definedtype error.✔️ PR Todo
export default classis not supported by Node ESM