Don't send HMR updates before packaging in watch mode#9026
Merged
Conversation
devongovett
approved these changes
May 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #8582, HMR updates are sent before bundles are written to disk because the dev server stalls any potential requests until the build is finished (and it never serves outdated bundles from the previous build).
But when not using the builtin dev server, outdated bundles will be served (non-deterministically depending on how quickly the browser triggers the page reload and how long Parcel takes to write all bundles).
Now, the optimization from that PR is only used when the builtin dev server is used (so not for
parcel watch). I don't think there's anything else we can hereCloses #8940