Add support for Chrome Extension manifest V3 side_panel property.#9178
Merged
mischnic merged 4 commits intoSep 27, 2023
Conversation
2 tasks
mischnic
reviewed
Sep 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
This pull request addresses an issue where the existing web extension plugin did not recognize the
side_panelproperty in Chrome Extension manifest V3, leading to the HTML files not being compiled and copied to the dist folder. With the recent support for theside_panelproperty in Google Chrome, this PR introduces the necessary changes to enable the plugin to recognize the property, ensuring proper compilation of the HTML files.The feature aligns with the latest chrome.sidePanel documentation from Chrome, ensuring compliance with the latest standards.
💻 Examples
For the manifest
Before:

The side_panel is not recognized by the
@parcel/config-webextensionso that the html is not bring to the dist folder.After

With the update, the HTML file for the
side_panelsettings is now correctly compiled and included in the dist folder.🚨 Test instructions
Integration tests for the new functionality have been added.
✔️ PR Todo