Skip to content

Fix unexpected undefined when creating shared bundles #9195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AGawrys merged 2 commits into from
Aug 23, 2023
Merged

Fix unexpected undefined when creating shared bundles #9195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4ee4c2
initial test case & fix
AGawrys Aug 14, 2023
7dc348a
Merge branch 'v2' into css-module-bug
AGawrys Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/bundlers/default/src/DefaultBundler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -960,7 +960,7 @@ function createIdealGraph(

// Create shared bundles for splittable bundles.
if (reachable.length > config.minBundles) {
let sourceBundles = reachable.map(a => nullthrows(bundles.get(a.id)));
let sourceBundles = reachable.map(a => nullthrows(bundleRoots.get(a))[0]);
let key = reachable.map(a => a.id).join(',');
let bundleId = bundles.get(key);
let bundle;
Expand Down
27 changes: 27 additions & 0 deletions packages/core/integration-tests/test/css-modules.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,6 +547,33 @@ describe('css modules', () => {
},
]);
});

it('should not fail with many css modules', async function () {
let b = await bundle(
path.join(__dirname, '/integration/css-modules-bug/src/index.html'),
);

assertBundles(b, [
{
name: 'index.html',
assets: ['index.html'],
},
{
type: 'js',
assets: [
'button.module.css',
'main.js',
'main.module.css',
'other.module.css',
],
},
{
type: 'css',
assets: ['button.module.css', 'main.module.css', 'other.module.css'],
},
]);
});

// Forked because experimental bundler will not merge bundles of same types if they do not share all their bundlegroups
it('should handle @import in css modules', async function () {
let b = await bundle(
Expand Down
3 changes: 3 additions & 0 deletions packages/core/integration-tests/test/integration/css-modules-bug/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{

}
3 changes: 3 additions & 0 deletions packages/core/integration-tests/test/integration/css-modules-bug/src/button.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
.buttonPrimary {
align-self: center;
}
5 changes: 5 additions & 0 deletions packages/core/integration-tests/test/integration/css-modules-bug/src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<!DOCTYPE html>

<html lang="en">
<script src="main.js" type="module"></script>
</html>
4 changes: 4 additions & 0 deletions packages/core/integration-tests/test/integration/css-modules-bug/src/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
import * as main from "./main.module.css";
import * as other from "./other.module.css";

console.log([main.main, other.other]);
3 changes: 3 additions & 0 deletions packages/core/integration-tests/test/integration/css-modules-bug/src/main.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
.main {
composes: buttonPrimary from "./button.module.css";
}
3 changes: 3 additions & 0 deletions packages/core/integration-tests/test/integration/css-modules-bug/src/other.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
.other {
composes: buttonPrimary from "./button.module.css";
}
Empty file added packages/core/integration-tests/test/integration/css-modules-bug/yarn.lock
View file
Open in desktop
Empty file.
⚡