Fix shorthand identifier import usage#9222
Merged
Merged
Conversation
jondlm
commented
Aug 29, 2023
| // | ||
| // import { foo } from "bar"; | ||
| // const baz = { foo }; | ||
| if self.imports.contains_key(&id!(node)) { |
Contributor
Author
There was a problem hiding this comment.
I couldn't think of any cases where this new visitor would be problematic since SWC seems to imply that checking the id here helps us uniquely identify the correct use accounting for scope. Let me know if I'm wrong! I am very new to using Rust with SWC.
Contributor
Author
|
Perhaps @mischnic could take a look at this one when you have time? |
devongovett
approved these changes
Sep 11, 2023
1 task
mischnic
approved these changes
Sep 14, 2023
mischnic
left a comment
mischnic
left a comment
Member
There was a problem hiding this comment.
Seems like object shorthand is one of the few cases where there's an actual identifier that isn't/can't be an expression (all of the other cases are handled by visit_expr)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Fixes #9140 by adding a new SWC visitor to the JS transformer. It visits all identifiers, checks if their IDs match any of the previously detected imports. If so it adds them to the
used_importsset.💻 Examples
See #9140 for an outline of the bug this fixes.
🚨 Test instructions
I added an integration test that fails before this change and passes after. I couldn't find unit tests for the JS transformer so I'm assuming an integration test is appropriate here. I used @lettertwo's new
fsFixturehelper to colocate the test files with the actual test. That worked quite nicely!✔️ PR Todo