Skip to content

Progress messages for writing to cache#9368

Merged
thebriando merged 12 commits into
v2from
bdo/cache-progress
Nov 30, 2023
Merged

Progress messages for writing to cache#9368
thebriando merged 12 commits into
v2from
bdo/cache-progress

Conversation

@thebriando

Copy link
Copy Markdown
Contributor

↪️ Pull Request

Writing to cache on shutdown can take a long time for large graphs, which makes it looks like Parcel is hanging after hitting ctrl-c. This moves the shutdown message to Parcel.js so it logs out right away, and also adds a progress bar indicator for the blobs written to cache.

This behavior will only happen for large graphs (>5000 nodes) but this number can be changed if needed.

💻 Examples

Screen.Recording.2023-11-08.at.4.15.07.PM.mov

🚨 Test instructions

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@lettertwo

Copy link
Copy Markdown
Contributor

Should the progress bar rendering be the responsibility of the CLIReporter? Having the RequestTracker do it is circumventing the reporter plugins entirely.

Maybe there should be a new ReporterEvent that represents this progress, and the CLIReporter can handle those events by rendering the progress bar.

@thebriando

Copy link
Copy Markdown
Contributor Author

I ran into some problems in the unit tests with using the report api but it should work now with the change in #9396

Comment thread packages/core/core/src/Parcel.js Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants