Mark previously deferred assets as dirty for symbol prop

[mattcompiles]

↪️ Pull Request

This PR fixes an issue in incremental symbol propagation + lazy mode builds where you have a lazy asset that depends on an asset which is also lazy itself. The issue occurs because propagateSymbolsDown is skipped but propagateSymbolsUp runs after the lazy bundle is requested. This can cause an incorrect "X does not export 'Y'" error to show as the usedSymbolsDown property has not been populated correctly.

flowchart LR
    Main -.-> Async
    Main -.-> SharedAsync
    Async --> SharedAsync

Loading

This fix here is to mark previously deferred assets and their dependencies as changed/dirty so symbol propagation knows to re-process them.

✔️ PR Todo

• Added/updated unit tests for this change
• Filled out test instructions (In case there aren't any unit tests)
• Included links to related issues/PRs

[marcins]

Nice one! Love those problems that take days of digging only to result in a tiny change to fix.

[mischnic]

Do you know why this only happens if the full pass runs? Feels odd to me

[mattcompiles]

There are other circumstances that can cause this to occur outside of a full pass, however this was the easiest way to reflect in a test. The reason is fails though is because the full pass only applies to propagateSymbolsUp. However, in this case there are nodes that are not re-visited by propagateSymbolsDown and contain stale data.