Fix dependency retargeting with ambiguous reexports#9380
Merged
Conversation
thebriando
approved these changes
Nov 14, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a regression of #9331 that broke the REPL
For the usual problem of ambiguous reexport-all, the first reexport would simply win (but in reality this should be determined at runtime) and sets itself in the importer asset's symbols. (lib-a.js is empty, the other two branches contain pure ESM exports of
bandcrespectively)If the exports aren't renamed (
from == as) then we can just add a* -> *reexport-all dependency. This doesn't require changing the importers symbols (which can only list a single, therefore unambiguous, resolution). All ambiguous situation should fall in this non-renaming caseAt some point, we should really rethink how we want to support reexporting from non-statically analyzable CJS...