VSC Extension JSON schema#9386
Merged
Merged
Conversation
celinanperalta
approved these changes
Dec 5, 2023
celinanperalta
left a comment
celinanperalta
left a comment
Contributor
There was a problem hiding this comment.
lgtm! nice addition
thebriando
approved these changes
Dec 5, 2023
lukaw3d
reviewed
Jan 12, 2024
| "type": "object", | ||
| "properties": { | ||
| "context": { | ||
| "description": "The context property defines what type of environment to build for. This tells Parcel what environment-specific APIs are available, e.g. the DOM, Node filesystem APIs.", |
Contributor
There was a problem hiding this comment.
Some of this JSON duplicates what https://github.com/parcel-bundler/parcel/blob/9d6da2c/packages/core/core/src/TargetDescriptor.schema.js does, but descriptions seem novel.
I think if you add descriptions into TargetDescriptor.schema.js, you can just generate this file. (my script for generating json from TargetDescriptor.schema.js https://github.com/lukaw3d/parcel-bundler-json-schemas/blob/main/main.js)
| @@ -0,0 +1,94 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add autocomplete/popup descriptions/always-on schema validation for .parcelrc and
package.json#targetsparcel-lsp-jsonschema.mov
Plus descriptions
Two aspects that are suboptimal are (could be solved in the future with a custom LSP for the JSON as well):
parcel-{type}-*pattern)