Skip to content

Filter --expose-gc and --max-semi-space-size execArgv Node args from workers#9399

Merged
mischnic merged 1 commit into
parcel-bundler:v2from
davidjb:filter-lambda-execv-flags
Nov 23, 2023
Merged

Filter --expose-gc and --max-semi-space-size execArgv Node args from workers#9399
mischnic merged 1 commit into
parcel-bundler:v2from
davidjb:filter-lambda-execv-flags

Conversation

@davidjb

@davidjb davidjb commented Nov 23, 2023

Copy link
Copy Markdown
Contributor

↪️ Pull Request

This filters --expose-gc and --max-semi-space-size flags from being passed to Parcel workers to fix the issue described at #9398, allowing Parcel workers to function when these flags are used, such as within an AWS Lambda environment.

💻 Examples

See #9398 for details of the AWS execution environment and Node options it sets.

🚨 Test instructions

test.js:

const { createWorkerFarm } = require('@parcel/core');
createWorkerFarm();

Run with node --expose-gc --max-semi-space-size=17 test.js and ensure no exceptions were raised.

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Worker threads crash if --expose-gc or --max-semi-space-size are passed in execArgv

2 participants