Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions packages/optimizers/inline-requires/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,9 @@ Add this optimizer to run _first_ (before minification), for JS bundles.

```json
{
"optimizers": {
"*.js": {
"parcel-optimizer-inline-requires",
"..."
}
}
"optimizers": {
"*.js": ["@parcel/optimizer-inline-requires", "..."]
}
}
```

Expand Down
31 changes: 24 additions & 7 deletions packages/optimizers/inline-requires/src/InlineRequires.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,23 @@ type BundleConfig = {|

// $FlowFixMe not sure how to anotate the export here to make it work...
module.exports = new Optimizer<empty, BundleConfig>({
loadBundleConfig({bundleGraph, logger}): BundleConfig {
loadBundleConfig({bundle, bundleGraph, tracer}): BundleConfig {
if (publicIdToAssetSideEffects !== null) {
return {publicIdToAssetSideEffects};
}

publicIdToAssetSideEffects = new Map<string, SideEffectsMap>();
logger.verbose({
message: 'Generating publicIdToAssetSideEffects for require optimisation',
});

if (!bundle.env.shouldOptimize) {
return {publicIdToAssetSideEffects};
}

const measurement = tracer.createMeasurement(
'@parcel/optimizer-inline-requires',
'generatePublicIdToAssetSideEffects',
bundle.name,
);

bundleGraph.traverse(node => {
if (node.type === 'asset') {
const publicId = bundleGraph.getAssetPublicId(node.value);
Expand All @@ -32,17 +40,26 @@ module.exports = new Optimizer<empty, BundleConfig>({
});
}
});
logger.verbose({message: 'Generation complete'});

measurement && measurement.end();

return {publicIdToAssetSideEffects};
},

async optimize({bundle, options, contents, map, logger, bundleConfig}) {
if (options.mode !== 'production') {
async optimize({bundle, contents, map, tracer, logger, bundleConfig}) {
if (!bundle.env.shouldOptimize) {
return {contents, map};
}

try {
const measurement = tracer.createMeasurement(
'@parcel/optimizer-inline-requires',
'parse',
bundle.name,
);
const ast = await parse(contents.toString());
measurement && measurement.end();

const visitor = new RequireInliningVisitor({
bundle,
logger,
Expand Down