Skip to content

Print phase times on development builds#9417

Merged
imbrian merged 10 commits into
v2from
imbrian/incremental-bundle-timings
Dec 7, 2023
Merged

Print phase times on development builds#9417
imbrian merged 10 commits into
v2from
imbrian/incremental-bundle-timings

Conversation

@imbrian

@imbrian imbrian commented Dec 4, 2023

Copy link
Copy Markdown
Contributor

↪️ Pull Request

Phase timings can currently be shown via PARCEL_SHOW_PHASE_TIMES on production mode builds.

This PR extends this to development builds, resetting phase start times on the first buildProgress after a buildSuccess, so phase times can be debugged on incremental development builds.

✔️ PR Todo

  • Added/updated unit tests for this change
  • Included links to related issues/PRs

@imbrian imbrian requested a review from irismoini December 4, 2023 18:25

@irismoini irismoini left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥳

@imbrian imbrian merged commit ecfeb40 into v2 Dec 7, 2023
@imbrian imbrian deleted the imbrian/incremental-bundle-timings branch December 7, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants