Configurable watch root#9424
Merged
devongovett merged 12 commits intoDec 19, 2023
Merged
Conversation
jondlm
commented
Dec 7, 2023
devongovett
reviewed
Dec 13, 2023
| resolvedOptions.projectRoot, | ||
| resolvedOptions.watchDir, | ||
| (err, events) => { | ||
| if (err) { |
Member
There was a problem hiding this comment.
we should probably also update this so it works for one-shot builds
parcel/packages/core/core/src/RequestTracker.js
Line 1217 in e4f0a69
idk if watchRoot is the most obvious name in that case but not sure about another one. projectRoot is a different thing and affects more stuff so would need to be something different.
Contributor
Author
There was a problem hiding this comment.
Done! Yeah the name because less intuitive when used in this context :|
devongovett
approved these changes
Dec 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to: #4332
↪️ Pull Request
Adds a new
--watch-dirCLI flag that allows users to specify a directory higher up than the project root. This allows Parcel in watch mode to detect changes to symlinked dependencies.This is especially useful for monorepos that have lockfiles for each of the projects and where all projects can't share the same project root for various reasons.
💻 Examples
Suppose we have a project shaped like this:
We can run
parcel server --watchDir ../..from withinpackages/appand changes topackages/lib/index.jswill trigger HMR updates, etc.🚨 Test instructions
I have included an integration test that exercises this new behavior. I confirmed that without the
watchDiroption Parcel won't detect changes but it does with the proper watch directory set.✔️ PR Todo