Skip to content

Bump rimraf version to ^5.05#9438

Merged
mischnic merged 8 commits into
v2from
achan3/VULN-1129102-update-rimraf-create-react-app
Dec 14, 2023
Merged

Bump rimraf version to ^5.05#9438
mischnic merged 8 commits into
v2from
achan3/VULN-1129102-update-rimraf-create-react-app

Conversation

@adelchan07

Copy link
Copy Markdown
Contributor

Bump rimraff version in response to a security vulnerability within Atlassian products

↪️ Pull Request

💻 Examples

🚨 Test instructions

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@mischnic

Copy link
Copy Markdown
Member
  • We might as well upgrade to the latest version then (v5)
  • A breaking change of v4 was the the methods return promises now, so the promisify in packages/utils/create-react-app/src/cli.js shouldn't be done anymore
  • (There is still a dependency on the old version in the monorepo root)

@adelchan07 adelchan07 changed the title Bump rimraf version in @create-react-app Bump rimraf version to ^5.05 Dec 14, 2023
@adelchan07 adelchan07 force-pushed the achan3/VULN-1129102-update-rimraf-create-react-app branch from 4005017 to fff85f7 Compare December 14, 2023 17:43
@mischnic

Copy link
Copy Markdown
Member

The flow types in flow-typed/npm/rimraf_v2.x.x.js are wrong now, it should be something like this now

  declare module.exports: {
    (f: string, opts?: Options): Promise<boolean>,

And the gulpfile has to be changed:

diff --git gulpfile.js gulpfile.js
index 4b524e694..61d885410 100644
--- gulpfile.js
+++ gulpfile.js
@@ -59,7 +59,10 @@ class TapStream extends Transform {
 }
 
 exports.clean = function clean(cb) {
-  rimraf('packages/*/*/lib/**', cb);
+  rimraf('packages/*/*/lib/**').then(
+    () => cb,
+    err => cb(err),
+  );
 };

@mischnic mischnic merged commit 13e6cfd into v2 Dec 14, 2023
@mischnic mischnic deleted the achan3/VULN-1129102-update-rimraf-create-react-app branch December 14, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants