Ensure Asset public ids are assigned deterministically#9706
Merged
Conversation
marcins
approved these changes
May 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
We've been seeing issues internally where public Ids are not deterministic between two builds on the same commit and options. I believe this is related to how we iterate over the nodes array directly to assign the public Ids rather than using a DFS. As Assets are transformed off-thread, it's possible Assets are added to the graph in different order between builds, therefore the node Array is not deterministic.
This PR instead uses a dfs to ensure the nodes are visited in order. In the full Jira AssetGraph I measured a 100ms performance loss using DFS instead which I think is acceptable in this case.