Ensure const modules in async bundles are wrapped#9740
Merged
Conversation
| ); | ||
|
|
||
| // This will fail when the async bundle does not export it's constant | ||
| await run(b); |
Contributor
There was a problem hiding this comment.
Does the asset still get inlined in this case? It wouldn't be ideal if you ended up with something like:
import('./async').then(m => console.log('async value'));
Contributor
Author
There was a problem hiding this comment.
Good question, it doesn't seem to - I assume the static analysis can't track the usage to that level anyway?
From the bundle in the integration test:
(parcelRequire("8Vicm")).then((m)=>console.log(m.value));
Contributor
Author
There was a problem hiding this comment.
I've added additional verification in the integration test.
MonicaOlejniczak
approved these changes
May 28, 2024
mattcompiles
approved these changes
May 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
This fixes a case where an async module only exports a constant, and it doesn't end up getting registered.
We had a use case where there were lots of async bundles containing just string exports for a PDF renderer, and a big switch case that would dynamically import fonts on demand. These small async bundles weren't registering their exports.
Pseudo example based on the real pattern - where the real values could vary in size between several hundred bytes and 60KB+, hence deferred loading:
🚨 Test instructions
✔️ PR Todo