12x faster resolver cache#9984
Merged
Merged
Conversation
# Conflicts: # packages/utils/node-resolver-rs/src/path.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rewrites the resolver cache to be much more efficient. Instead of storing data in a bunch of separate hash maps, this creates a new
CachedPathdata structure that stores information about paths in a single place. This includes a direct reference to the parent path, a pre-computed hash of the path, lazily loaded file kind (e.g. file/dir/symlink), canonical path, and parsed package.json/tsconfig.json.CachedPathreferences this info via anArc, so it is cheap to compare, hash, and clone compared with aPathBuf. It can also perform common operations like appending a sub-path or file extension cheaply via a reusable thread local scratch path, avoiding intermediary allocations.