Remove dependency on insecure crypto/md5 package#113
Closed
pkumar0508 wants to merge 1 commit intopaulmach:masterfrom
pkumar0508:patch-1
Closed
Remove dependency on insecure crypto/md5 package#113pkumar0508 wants to merge 1 commit intopaulmach:masterfrom pkumar0508:patch-1
pkumar0508 wants to merge 1 commit intopaulmach:masterfrom
pkumar0508:patch-1
Conversation
crypto/sha256 is a suitable replacement as the standard library also provides it. This change only affects test code.
Author
|
Thanks for #118 ! It satisfies my needs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crypto/sha256is a suitable replacement as the standard library also provides it. This change only affects test code.To be clear, I know this pull request looks a little silly, replacing a broken hash in one test. New dependencies on
crypto/md5have been disallowed in the codebase I'm trying to usegithub.com/paulmach/orbin. Given the change is small, easy, only affects test code, doesn't increase test runtime noticeably, and might resolve warnings about this dependency that other developers might run into, I figure I would send you a PR.