feat(encoding/mvt): support mvt marshal for GeometryCollection#89
Merged
paulmach merged 2 commits intopaulmach:masterfrom Apr 3, 2022
Merged
feat(encoding/mvt): support mvt marshal for GeometryCollection#89paulmach merged 2 commits intopaulmach:masterfrom
paulmach merged 2 commits intopaulmach:masterfrom
Conversation
Owner
|
I agree with this PR. Why not support geometry collections by encoding each geometry separately. Makes sense. The only possible issue is that it's no longer a close mapping between geojson and mvt. if you go geojson -> mvt -> geojson the collection will become individual features. Not a big deal, but FYI. However, this has nothing to do with winding-order. Winding-order refers to the individual rings within a single polygon. That is fully supported by the existing code. |
Owner
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
support collection marshaling in mvt.
winding-ordersample