Skip to content

feat(encoding/mvt): support mvt marshal for GeometryCollection#89

Merged
paulmach merged 2 commits intopaulmach:masterfrom
dadadamarine:mvtGeometryCollection
Apr 3, 2022
Merged

feat(encoding/mvt): support mvt marshal for GeometryCollection#89
paulmach merged 2 commits intopaulmach:masterfrom
dadadamarine:mvtGeometryCollection

Conversation

@dadadamarine
Copy link
Copy Markdown
Contributor

support collection marshaling in mvt.

@paulmach
Copy link
Copy Markdown
Owner

I agree with this PR. Why not support geometry collections by encoding each geometry separately. Makes sense. The only possible issue is that it's no longer a close mapping between geojson and mvt. if you go geojson -> mvt -> geojson the collection will become individual features. Not a big deal, but FYI.

However, this has nothing to do with winding-order. Winding-order refers to the individual rings within a single polygon. That is fully supported by the existing code.

@paulmach paulmach merged commit 53b70e2 into paulmach:master Apr 3, 2022
@paulmach
Copy link
Copy Markdown
Owner

paulmach commented Apr 3, 2022

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants