Add debouncing to readdirp call#690
Merged
es128 merged 1 commit intopaulmillr:masterfrom Apr 27, 2018
Merged
Conversation
srguiwiz
added a commit
to srguiwiz/chokidar
that referenced
this pull request
May 27, 2018
This was referenced May 27, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: #685
Previously, when an fs event was fired while a readdir throttle already existed, readdirp would not get called as the result of that event. If the existing/in-progress readdirp call didn't reflect the correct fs tree, e.g. if a new file was added in the middle of the readdirp call, then chokidar wouldn't pick up that the file was added until the next fs event occurred.
This PR adds leading/trailing debouncing to readdirp. If an event comes in while readdirp is already in progress, readdirp will be called again once the existing readdirp is finished.