Adding network toggle command + power button command#55
Closed
fmatosqg wants to merge 1 commit intopbreault:masterfrom
Closed
Adding network toggle command + power button command#55fmatosqg wants to merge 1 commit intopbreault:masterfrom
fmatosqg wants to merge 1 commit intopbreault:masterfrom
Conversation
This was referenced Nov 11, 2016
|
Can this be merged? Is a very welcome addition. |
fmatosqg
force-pushed
the
internet_command
branch
from
2e26a01 to
1853e11
Compare
Contributor
Author
|
@karntrehan thx for reminder, I noticed a small misbehavior though, when turning off internet on an emulator that didn't have the project's apk app installed I'm getting an error. Installing the debug version fixes the problem. |
fmatosqg
force-pushed
the
internet_command
branch
from
1853e11 to
42aa15d
Compare
Contributor
Author
|
@pbreault rebased to master, ready to be merged again |
Contributor
|
@fmatosqg Any updates? Can you fix the conflicting filse? |
Contributor
Author
|
No point if it won't be merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed when doing
./gradlew clean buildPluginit fails, but./gradlew clean buildPlugin ; ./gradlew buildPluginthen it works. The main trunk master branch also has this behaviour.