feat: dynamic comments and MarshalToml interface implementation#1014
Open
someshkoli wants to merge 12 commits intopelletier:v2from
Open
feat: dynamic comments and MarshalToml interface implementation#1014someshkoli wants to merge 12 commits intopelletier:v2from
someshkoli wants to merge 12 commits intopelletier:v2from
Conversation
Author
resolved 🙌 |
Owner
|
Hi! Thank you for looking at this. Seems like tests are failing. After fixing them, can you paste benchstat results please? I'd love to see the impact of the interface implementation checks. |
Author
|
Lost track of time with this one, will update the pr Also, we've been using this in nuonco/nuon since few months now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr was primarily inspired by the need to have dynamic comments, I noticed that we had dropped the plan for dynamic comments from v2 . While writing this, came across case where MarshalToml wouldve been very handy similar to MarshalJSON so the pr contains that as well.
End results can be found in test cases written.
We introduce
func TomlComment() stringinterface andfunc MarshalToml() ([]byte, error)interface to achieve both the things.Open to inputs and improvements so we can land this 🚀
Paste
benchstatresults here