Open
Conversation
pelletier
reviewed
Apr 7, 2025
Owner
pelletier
left a comment
There was a problem hiding this comment.
Do you mind sharing a benchstat result? just want to make sure passing that *decoder / *encoder pointer along doesn't have a negative impact on performance.
| // | ||
| // The encoding of each public struct field can be customized by the format | ||
| // string in the "toml" key of the struct field's tag. This follows | ||
| // string in the "toml" (or custom) key of the struct field's tag. This follows |
Owner
There was a problem hiding this comment.
Suggested change
| // string in the "toml" (or custom) key of the struct field's tag. This follows | |
| // string in the "toml" (or custom) key of the struct field's tag. This follows |
| // symbol. | ||
| // | ||
| // In addition to the "toml" tag struct tag, a "comment" tag can be used to emit | ||
| // In addition to the "toml" (or custom ) tag struct tag, a "comment" tag can be used to emit |
Owner
There was a problem hiding this comment.
Suggested change
| // In addition to the "toml" (or custom ) tag struct tag, a "comment" tag can be used to emit | |
| // In addition to the "toml" (or custom) tag struct tag, a "comment" tag can be used to emit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows for custom field tags to be set when doing toml encoding and decoding. This allows for a single tag to be used for fields in structures that may be encoded/decoded to various formats.
For example, the default tag being used is
toml. With this change, any tag may be used to encode / decode by calling theSetFieldTagmethod on the respective encoder or decoder.benchstat results