Skip to content

Upgrade GitHub actions versions to avoid node deprecation#2613

Closed
timkpaine wants to merge 1 commit intomasterfrom
tkp/node22
Closed

Upgrade GitHub actions versions to avoid node deprecation#2613
timkpaine wants to merge 1 commit intomasterfrom
tkp/node22

Conversation

@timkpaine
Copy link
Copy Markdown
Member

@timkpaine timkpaine commented May 10, 2024

We are currently using some older GitHub actions that raise

Screenshot 2024-05-16 at 09 20 53

@timkpaine timkpaine changed the title Switch from assert json to with json, node 22 on macos Upgrade node version May 10, 2024
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
@texodus
Copy link
Copy Markdown
Member

texodus commented May 16, 2024

Thanks for the PR!

This doesn't build on CI or locally (for me). I'm sure you experienced an issue but I can't say what it was.

@texodus texodus closed this May 16, 2024
@timkpaine
Copy link
Copy Markdown
Member Author

timkpaine commented May 16, 2024

I think it's only for node 22 (Change the keyword from assert to with) which is not yet on GHA, I'm going to back out those changes and just leave the actions upgrades (which we should take care of as they're spitting out deprecation warnings).

@timkpaine timkpaine changed the title Upgrade node version Upgrade GitHub actions versions to avoid node deprecation May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants