Open
Conversation
marhom
commented
Sep 20, 2024
| local name = UnitBuff("player", i) | ||
| if not name or cameraBuffs[name] then | ||
| inCamera = name and cameraBuffs[name] | ||
| local playerAura = C_UnitAuras.GetBuffDataByIndex("player", i) |
Author
There was a problem hiding this comment.
Not sure how you'd prefer to do stuff like this / handle the fact that the returned object is a little more complex; as mentioned, newish to Lua so the truthiness of everything isn't as immediately clear - this can be done more elegantly but lol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API updates and a very small related code change to extract the name from the table object that's returned by the new equivalent of UnitBuff.
Ran some quick tests including checking off achievement credit and everything seemed okay! I've barely ever touched Lua before but these changes are trivial, so I don't think there's any real risk.