fix CloseDropDownMenus() closing active dropdowns prematurely (#2) and backdrop API for patch 9.0+#3
Open
wardz wants to merge 2 commits intophanx-wow:masterfrom
Open
fix CloseDropDownMenus() closing active dropdowns prematurely (#2) and backdrop API for patch 9.0+#3wardz wants to merge 2 commits intophanx-wow:masterfrom
wardz wants to merge 2 commits intophanx-wow:masterfrom
Conversation
wardz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch 8.3.0 made a change that calls
CloseDropDownMenusevery time you click something on your screen. This causes the phanx-dropdown(s) to be closed right before you click a dropdown entry and thusListButton_OnClickwill never be triggered and no entry will be selected.This PR fixes that issue by checking for an
isActiveflag before trying to close any phanx dropdowns. (Will betruefor the most recently opened & visible dropdown)Edit: Seems the author is no longer active on Github at all. For anyone reading, i'm hosting a fork of this project here for now.