Conversation
Used as the tooltip on the AI live preview inspection banner now that the whole banner is clickable to dismiss.
Adds .ai-onboarding-prompt-images thumbnail row styling used by the onboarding review overlay when the iframe sends reference images alongside a userPrompt.
Adds two pieces of instrumentation/UX to the onboarding tour: - Per-step click metrics. Every step's highlighted target now has a one-shot capture-phase listener that fires stepN_clicked when the user actually clicks the ripple target during the overlay session. Detaches automatically on first click, on step transitions, and on teardown so we never double-count. - Step 2 AI-panel auto-peek. When step 2 begins, briefly switch the sidebar to the AI tab for 2 seconds and then revert to whatever tab the user was on. Throttled and cleaned up on transitions/teardown so the sidebar can't get stranded on AI if the tour ends mid-peek.
Adds src/view/VideoPlayer.js — small AMD module exporting createPlayer that returns a jQuery-wrapped <video> with sensible defaults (controls on, muted, playsinline, preload=metadata) and overridable flags. Built to back AI-panel onboarding's new embedded-video surface and any future inline-video usage without each caller re-deriving the same defaults. Also extends Extn-AIChatPanel.less with .ai-intro-video-player so the embedded <video> matches the existing thumbnail's 16:9, 320px max, rounded-corner envelope. Layout stays identical regardless of which mode (thumbnail-link vs embedded) the config picks.
Adds a fullscreen-overlay entry point to view/VideoPlayer alongside the
existing inline createPlayer:
VideoPlayer.renderFullScreenPlayer(srcElement, { src, poster, ... })
Opens a viewport-covering overlay with a large autoplaying player that
expands out of `srcElement` (Mac-dock-genie style via FLIP transform)
and contracts back to it on close. Click on the dimmed backdrop, the
close (×) button, or pressing Escape closes the overlay; clicks on the
video itself stay live so the user can scrub / unmute / fullscreen
without dismissing.
Stylesheet lives in src/styles/VideoPlayer.less (imported from
brackets.less) instead of being injected from JS — same place every
other view module's styles live. The AI panel's old in-place
.ai-video-lightbox rules are removed since the AI panel now just calls
renderFullScreenPlayer.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.