Skip to content

hide dropdown in design mode and element getting clipped #2881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abose merged 2 commits into from
May 1, 2026
+9 −6
Merged

hide dropdown in design mode and element getting clipped #2881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be70678
fix: hide mode dropdown chevron in design mode
devvaannsh May 1, 2026
f859472
fix: auto-size pro upgrade dialog info panel to fit translations
devvaannsh May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/extensionsIntegrated/Phoenix-live-preview/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,8 +343,9 @@
* Does not hide in custom server mode (handled by _isMdviewrActive being false).
*/
function _updateLPControlsForMdviewer() {
const inDesignMode = WorkspaceManager.isInDesignMode && WorkspaceManager.isInDesignMode();

Check warning on line 346 in src/extensionsIntegrated/Phoenix-live-preview/main.js

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 


See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZ3i2QWTWMXTFZC4Evuu&open=AZ3i2QWTWMXTFZC4Evuu&pullRequest=2881
const showPen = !_isMdviewrActive;
const showChevron = !_isMdviewrActive;
const showChevron = !_isMdviewrActive && !inDesignMode;
if ($previewBtn) {
$previewBtn.toggle(showPen);
}
Expand Down Expand Up @@ -898,7 +899,7 @@
$designModeBtn.attr("title",
on ? Strings.CCB_SWITCH_TO_CODE_EDITOR : Strings.CCB_SWITCH_TO_DESIGN_MODE);
if ($modeBtn) {
$modeBtn.toggle(!_isMdviewrActive);
$modeBtn.toggle(!on && !_isMdviewrActive);
}
}
$designModeBtn.click(()=>{
Expand Down
10 changes: 6 additions & 4 deletions src/styles/phoenix-pro.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,10 +229,10 @@
transform: scale(1.25);
}

/* ---- Info panel below the stage ---- */
.feature-info {
position: relative;
height: 70px;
display: grid;
grid-template-areas: "stack";
background: @bc-panel-bg-alt;
border-top: 1px solid @bc-panel-border;
overflow: hidden;
Expand All @@ -245,8 +245,10 @@
/* Mirror the .feature-slide transform/cross-fade so the text below the
video animates in the same direction as the video stage. */
.feature-info-slide {
position: absolute;
inset: 0;
grid-area: stack;
display: flex;
flex-direction: column;
justify-content: center;
padding: 10px 28px;
opacity: 0;
pointer-events: none;
Expand Down
Loading
⚡