Add GitHub Enterprise setting as env var#201
Open
RichardLitt wants to merge 1 commit intophilschatz:masterfrom
Open
Add GitHub Enterprise setting as env var#201RichardLitt wants to merge 1 commit intophilschatz:masterfrom
RichardLitt wants to merge 1 commit intophilschatz:masterfrom
Conversation
Here, I add process.env.GITHUB_ENDPOINT as a possible environmental var to use to change the rootURL. I change all instances of `rootURL` to `githubEndpoint`, as that is the token used in [`gh-got`](https://github.com/sindresorhus/gh-got) and it seemed like a good idea to just copy that token. I was unsure of how to add a test for this.
Contributor
Author
|
Just realized changing I resolved my issues in RichardLitt/gh-description#12 using rootURL, so this PR is no longer necessary for me, but it may still be useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here, I add process.env.GITHUB_ENDPOINT as a possible environmental var
to use to change the rootURL. I change all instances of
rootURLtogithubEndpoint, as that is the token used ingh-gotand it seemed like a good idea to just copy that token.
I was unsure of how to add a test for this.