[WIP][refactor] Attach methods to prototype instead of object.#60
Open
cirosantilli wants to merge 1 commit intophilschatz:masterfrom
Open
[WIP][refactor] Attach methods to prototype instead of object.#60cirosantilli wants to merge 1 commit intophilschatz:masterfrom
cirosantilli wants to merge 1 commit intophilschatz:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doing:
@func = ->inside of the constructor attaches methods to objects, which uses extra memory if there are multiple objectsfunc: ->attaches to.prototype, so one per class.Since it is more efficient, it is also more common, and therefore easier to identify the instance methods.
Also requires using
@userinstead of_userclosure variable, which is good as it makes it clear what is an instance variable and what is a local one.If good I will do this for every class.
Only the 2 currently failing tests fail like before this PR.