Add webpack bundler#17361
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17361 +/- ##
=========================================
Coverage 49.38% 49.38%
Complexity 16660 16660
=========================================
Files 601 601
Lines 59686 59686
=========================================
+ Hits 29475 29477 +2
+ Misses 30211 30209 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
MauricioFauth
force-pushed
the
js-bundling-webpack
branch
2 times, most recently
from
2fc30a5 to
203366f
Compare
| }, | ||
| plugins: [ | ||
| new webpack.BannerPlugin({ | ||
| banner: 'OpenLayers (https://openlayers.org/)\nCopyright 2005-present, OpenLayers Contributors All rights reserved.\nLicensed under BSD 2-Clause License (https://github.com/openlayers/openlayers/blob/main/LICENSE.md)' |
There was a problem hiding this comment.
@williamdes I didn't find a way to add the package version like it had in the sync-js script.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
MauricioFauth
force-pushed
the
js-bundling-webpack
branch
from
203366f to
e46f043
Compare
|
The generated code is almost the same as before. |
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
MauricioFauth
force-pushed
the
js-bundling-webpack
branch
from
496d1b2 to
a179a60
Compare
| 'setup/styles': './setup/scss/styles.scss', | ||
| }, | ||
| output: { | ||
| filename: 'build/css/[name].js', |
There was a problem hiding this comment.
webpack generates these empty .js files. I don't know how to not generate them, so I chose to output them into the build directory.
| const CopyPlugin = require('copy-webpack-plugin'); | ||
| const WebpackConcatPlugin = require('webpack-concat-files-plugin'); | ||
| const MiniCssExtractPlugin = require('mini-css-extract-plugin'); | ||
| const WebpackRTLPlugin = require('webpack-rtl-plugin'); |
There was a problem hiding this comment.
We should revisit this plugin in the future, as it's triggering some deprecation messages. And looks like it's an abandoned plugin.
https://github.com/phpmyadmin/phpmyadmin/runs/5148016820?check_suite_focus=true#step:6:14
williamdes
left a comment
williamdes
left a comment
There was a problem hiding this comment.
This really looks nice, maybe the gitattributes file and the release script cleanup will need adjustments
2 participants
Adds webpack to bundle the JavaScript files and other assets.
The main difference from the previous attempt is that IIFE wrappers are not being added to code. So we don't need to declare every global in the source files.
Related to #15580