Extract url.php entry point into a route#17676
Merged
MauricioFauth merged 1 commit intophpmyadmin:masterfrom Aug 6, 2022
Merged
Extract url.php entry point into a route#17676MauricioFauth merged 1 commit intophpmyadmin:masterfrom
url.php entry point into a route#17676MauricioFauth merged 1 commit intophpmyadmin:masterfrom
Conversation
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Codecov Report
@@ Coverage Diff @@
## master #17676 +/- ##
============================================
+ Coverage 53.64% 53.73% +0.09%
- Complexity 16869 16871 +2
============================================
Files 617 616 -1
Lines 59600 60090 +490
============================================
+ Hits 31972 32292 +320
- Misses 27628 27798 +170
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
williamdes
reviewed
Aug 6, 2022
| $GLOBALS['containerBuilder']->set('theme_manager', ThemeManager::getInstance()); | ||
| Tracker::enable(); | ||
|
|
||
| if ($route === '/url') { |
Member
There was a problem hiding this comment.
It can be before tracking init
Ideally this should just work without dbi and things
Or not?
Member
Author
There was a problem hiding this comment.
Probably, yes. But I added it in the same order. We can check this later when refactoring the Common class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.