Skip to content

Fix #13773 - Export page of Settings is not responsive#17801

Merged
MauricioFauth merged 1 commit intophpmyadmin:masterfrom
Arpit-Gulgulia:ticket_13773
Oct 29, 2022
Merged

Fix #13773 - Export page of Settings is not responsive#17801
MauricioFauth merged 1 commit intophpmyadmin:masterfrom
Arpit-Gulgulia:ticket_13773

Conversation

@Arpit-Gulgulia
Copy link
Copy Markdown
Contributor

@Arpit-Gulgulia Arpit-Gulgulia commented Oct 15, 2022

Signed-off-by: Arpit-Gulgulia arpitgulgulia@gmail.com

Description

Please describe your pull request: Fix for 13773

Fixes #13773

Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.

@Arpit-Gulgulia
Copy link
Copy Markdown
Contributor Author

After changes, the page looks like the attached screenshot on a small screen and a large screen.
Mobile view:
image

Desktop view:
image

Hope this will helps the users.

@williamdes , please review the changes.
Thanks

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 15, 2022

Codecov Report

Base: 54.21% // Head: 54.15% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (603a249) compared to base (d01ec6b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #17801      +/-   ##
============================================
- Coverage     54.21%   54.15%   -0.07%     
+ Complexity    16935    16929       -6     
============================================
  Files           619      619              
  Lines         60042    59921     -121     
============================================
- Hits          32554    32450     -104     
+ Misses        27488    27471      -17     
Flag Coverage Δ
dbase-extension 54.05% <ø> (-0.08%) ⬇️
recode-extension 54.02% <ø> (-0.07%) ⬇️
unit-7.2-ubuntu-latest 54.02% <ø> (-0.08%) ⬇️
unit-7.3-ubuntu-latest 54.37% <ø> (-0.04%) ⬇️
unit-7.4-ubuntu-latest 54.37% <ø> (-0.04%) ⬇️
unit-8.0-ubuntu-latest 54.45% <ø> (-0.04%) ⬇️
unit-8.1-ubuntu-latest 54.32% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libraries/classes/Sanitize.php 88.78% <0.00%> (-2.52%) ⬇️
...ies/classes/Controllers/Table/SearchController.php 29.77% <0.00%> (-0.69%) ⬇️
libraries/classes/Types.php 95.22% <0.00%> (-0.66%) ⬇️
libraries/classes/Import/SimulateDml.php 82.45% <0.00%> (-0.60%) ⬇️
libraries/classes/Config/FormDisplayTemplate.php 88.88% <0.00%> (-0.59%) ⬇️
libraries/classes/Database/Qbe.php 50.67% <0.00%> (-0.55%) ⬇️
...classes/Controllers/Table/ZoomSearchController.php 30.32% <0.00%> (-0.51%) ⬇️
libraries/classes/Database/CentralColumns.php 60.86% <0.00%> (-0.26%) ⬇️
libraries/classes/Header.php 87.45% <0.00%> (-0.19%) ⬇️
...es/classes/Controllers/Export/ExportController.php 51.17% <0.00%> (-0.18%) ⬇️
... and 62 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, it can probably go to QA
Will test it soon

@williamdes williamdes added the UI Issues relating to the user interface label Oct 15, 2022
@williamdes williamdes changed the title Fix:13773 Export page of Setting is not responsive Fix #13773 - Export page of Setting is not responsive Oct 15, 2022
@williamdes williamdes changed the title Fix #13773 - Export page of Setting is not responsive Fix #13773 - Export page of Settings is not responsive Oct 15, 2022
@Arpit-Gulgulia
Copy link
Copy Markdown
Contributor Author

Nice one, it can probably go to QA Will test it soon

Hey @williamdes, did you get some time to test this? Hope it passed🙂
Please also add a hacktober-accepted tag.
Thanks!

Comment thread templates/config/form_display/display.twig Outdated
Signed-off-by: Arpit-Gulgulia <arpitgulgulia@gmail.com>
@Arpit-Gulgulia
Copy link
Copy Markdown
Contributor Author

@MauricioFauth , are we good the changes?

@MauricioFauth MauricioFauth merged commit 69bbe6c into phpmyadmin:master Oct 29, 2022
@MauricioFauth MauricioFauth self-assigned this Oct 29, 2022
@Arpit-Gulgulia Arpit-Gulgulia deleted the ticket_13773 branch October 29, 2022 12:20
@williamdes williamdes added this to the 5.3.0 milestone Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted UI Issues relating to the user interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Export page of Setting is not responsive

4 participants