Skip to content

Adds support for SHA2 function#17809

Merged
MauricioFauth merged 2 commits intophpmyadmin:masterfrom
liviuconcioiu:sha2
Oct 18, 2022
Merged

Adds support for SHA2 function#17809
MauricioFauth merged 2 commits intophpmyadmin:masterfrom
liviuconcioiu:sha2

Conversation

@liviuconcioiu
Copy link
Copy Markdown
Contributor

Signed-off-by: Liviu-Mihail Concioiu liviu.concioiu@gmail.com

Description

This PR adds support for SHA2 function.

Fixes #17760

Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 18, 2022

Codecov Report

Base: 54.17% // Head: 54.16% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (f1469f5) compared to base (0216137).
Patch coverage: 40.81% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #17809      +/-   ##
============================================
- Coverage     54.17%   54.16%   -0.01%     
  Complexity    16921    16921              
============================================
  Files           619      619              
  Lines         59924    59918       -6     
============================================
- Hits          32462    32455       -7     
- Misses        27462    27463       +1     
Flag Coverage Δ
dbase-extension 54.07% <40.81%> (-0.01%) ⬇️
recode-extension 54.04% <40.81%> (-0.01%) ⬇️
unit-7.2-ubuntu-latest 54.04% <40.81%> (-0.01%) ⬇️
unit-7.3-ubuntu-latest 54.37% <42.55%> (-0.02%) ⬇️
unit-7.4-ubuntu-latest 54.39% <42.55%> (-0.01%) ⬇️
unit-8.0-ubuntu-latest 54.45% <42.55%> (+0.01%) ⬆️
unit-8.1-ubuntu-latest 54.32% <42.55%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lasses/Controllers/Database/DesignerController.php 0.00% <0.00%> (ø)
...ies/classes/Controllers/Table/SearchController.php 29.77% <0.00%> (ø)
...classes/Controllers/Table/ZoomSearchController.php 30.32% <0.00%> (ø)
libraries/classes/Database/Designer.php 24.85% <0.00%> (ø)
libraries/classes/Display/Results.php 68.06% <0.00%> (ø)
libraries/classes/Navigation/Nodes/NodeTable.php 18.75% <0.00%> (ø)
libraries/classes/Types.php 95.22% <ø> (ø)
libraries/classes/Navigation/NavigationTree.php 54.95% <9.09%> (-0.07%) ⬇️
libraries/classes/InsertEdit.php 88.41% <50.00%> (-0.09%) ⬇️
libraries/classes/Navigation/Nodes/Node.php 57.01% <80.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@williamdes williamdes added the Enhancement A feature request for improving phpMyAdmin label Oct 18, 2022
@MauricioFauth MauricioFauth merged commit 5ab43f6 into phpmyadmin:master Oct 18, 2022
@MauricioFauth
Copy link
Copy Markdown
Member

Merged, thanks for your contribution!

@MauricioFauth MauricioFauth self-assigned this Oct 18, 2022
@liviuconcioiu liviuconcioiu deleted the sha2 branch October 18, 2022 19:16
@williamdes williamdes added this to the 5.3.0 milestone Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement A feature request for improving phpMyAdmin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Added cryptographic functions

4 participants